Skip to content

fix(chart): issue the operator webhook certificate from nebari-ca-issuer by default - #260

Open
dcmcand wants to merge 1 commit into
mainfrom
fix/chart-webhook-issuer
Open

dcmcand wants to merge 1 commit into
mainfrom
fix/chart-webhook-issuer

Conversation

@dcmcand

@dcmcand dcmcand commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Hold: do not merge until nebari-dev/nebari-infrastructure-core#787 merges. The new default, nebari-ca-issuer, only exists on NIC clusters that include it.

Slice 4: The operator's webhook certificate comes from a configurable issuer

The chart's webhook serving Certificate hardcoded ClusterIssuer selfsigned-issuer. Neither the chart nor NIC on main creates it, so on a fresh NIC cluster the operator pod sits in ContainerCreating (found during the live pre-flight for #233). nebari-infrastructure-core#787 gives every NIC cluster an internal CA and documents nebari-ca-issuer as the issuer packs use for in-cluster and webhook certificates.

Contracts touched: chart value operator.webhook.clusterIssuer (new, recorded in docs/architecture/contracts.md). The default changes from selfsigned-issuer to nebari-ca-issuer, which is a breaking default for clusters without that issuer; upgrading.mdx says how to keep the old one.
Depends on: nebari-dev/nebari-infrastructure-core#787 (merge order). Independent of the #173 / #258 stack. docs/architecture/contracts.md and AGENTS.md are also added by #258: AGENTS.md is identical, and contracts.md has the same header with different entries, so whichever merges second keeps both sets of entries.

What changes

  • values.yaml: operator.webhook.clusterIssuer: nebari-ca-issuer.
  • operator-webhook-cert.yaml: issuerRef.name comes from the value. A missing operator.webhook block (values reused from an older release with helm upgrade --reuse-values) renders the same default; an explicitly empty value fails the render. The two copies of the default carry keep-in-sync comments.
  • Docs: values reference, installation guide (prerequisite, issuer check, Argo CD values), quickstart and README prerequisites, and an upgrade note.

Validation

Step Result
helm lint charts/nebari-llm-serving/ 1 chart(s) linted, 0 chart(s) failed
default render issuerRef: {name: "nebari-ca-issuer", kind: ClusterIssuer}
--set operator.webhook.clusterIssuer=selfsigned-issuer name: "selfsigned-issuer"
--set operator.webhook.clusterIssuer= Error: ... operator.webhook.clusterIssuer is required: name an existing cert-manager ClusterIssuer to sign the operator webhook certificate
values without operator.webhook renders nebari-ca-issuer
full render vs main one line differs: name: selfsigned-issuer -> name: "nebari-ca-issuer"
docs npm run build complete (16 pages), npm test 31 passed

Live, on a fresh NIC Hetzner cluster built from #787's head:

  • helm upgrade --reuse-values from a release installed off main succeeds and renders nebari-ca-issuer.
  • Upgrade with the default: cert-manager reissued the webhook certificate at once from nebari-ca-issuer (issuer CN=Nebari root CA (<domain>), SANs the two .svc names), and cainjector updated the webhook caBundle. Admission calls failed with x509: certificate signed by unknown authority for about 65 s, until the operator reloaded the new certificate from its Secret volume; then admission worked. The upgrade note warns about this window.
  • Upgrade to an issuer that does not exist: the Secret is left untouched, the Certificate goes Ready=False/IncorrectIssuer, its CertificateRequest stays Pending, and admission keeps working with the old certificate until it expires.

@github-actions

Copy link
Copy Markdown

📄 Docs preview for fix/chart-webhook-issuer:
https://fix-chart-webhook-issuer.llm-serving-pack.pages.dev

…uer by default

The webhook serving Certificate hardcoded ClusterIssuer selfsigned-issuer,
which neither the chart nor NIC on main creates, so a fresh install left
the operator pod in ContainerCreating.

Add the chart value operator.webhook.clusterIssuer and default it to
nebari-ca-issuer, the internal CA NIC creates in releases that include
nebari-infrastructure-core#787. A missing operator.webhook block (values
reused from an older release with --reuse-values) renders the same
default; an explicitly empty value fails the render.

This changes the default for existing installs. The upgrade notes cover
keeping selfsigned-issuer, the brief admission failures while the
operator reloads the reissued certificate, and what happens when the
configured issuer does not exist. The installation guide, quickstart,
README and values reference list the new prerequisite, and
docs/architecture/contracts.md records the value as a contract.
@dcmcand
dcmcand force-pushed the fix/chart-webhook-issuer branch from 8404703 to e2ad1e8 Compare November 20, 2026 16:10

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This screenshot looks unrelated to the issuer change. Nothing links to it, and it sits outside docs/src/assets/, so the site never shows it. Please drop it from the PR.

@jbouder jbouder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants